fix: remove AZURE_RECORD_MODE override from Set-CliBuildVariables.ps1 - #7103
Merged
Conversation
The script unconditionally set AZURE_RECORD_MODE=playback as a pipeline variable before the test task runs, overriding the AzureRecordMode pipeline parameter introduced in PR #6893. This caused manually triggered LIVE test runs to still execute in playback mode. The record mode is now fully controlled by the AzureRecordMode parameter chain (release-cli.yml → build-and-test.yml → build-cli.yml). Fixes #7102 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vhvb1989
requested review from
danieljurek,
rajeshkamal5050 and
tg-msft
as code owners
March 12, 2026 21:27
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a pipeline-variable override in Set-CliBuildVariables.ps1 that forced AZURE_RECORD_MODE=playback, ensuring CLI test record mode is controlled solely by the AzureRecordMode pipeline parameter chain (per #6893), fixing manual runs incorrectly executing in playback.
Changes:
- Deleted the
##vso[task.setvariable]logic that setAZURE_RECORD_MODEtoplayback. - Added a clarifying comment pointing to the pipeline parameter flow that now controls
AZURE_RECORD_MODE.
You can also share your feedback on Copilot code review. Take the survey.
vhvb1989
enabled auto-merge (squash)
March 13, 2026 01:07
rajeshkamal5050
approved these changes
Mar 13, 2026
Member
Author
|
/check-enforcer override |
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 18, 2026
…Azure#7103) The script unconditionally set AZURE_RECORD_MODE=playback as a pipeline variable before the test task runs, overriding the AzureRecordMode pipeline parameter introduced in PR Azure#6893. This caused manually triggered LIVE test runs to still execute in playback mode. The record mode is now fully controlled by the AzureRecordMode parameter chain (release-cli.yml → build-and-test.yml → build-cli.yml). Fixes Azure#7102 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…Azure#7103) The script unconditionally set AZURE_RECORD_MODE=playback as a pipeline variable before the test task runs, overriding the AzureRecordMode pipeline parameter introduced in PR Azure#6893. This caused manually triggered LIVE test runs to still execute in playback mode. The record mode is now fully controlled by the AzureRecordMode parameter chain (release-cli.yml → build-and-test.yml → build-cli.yml). Fixes Azure#7102 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…Azure#7103) The script unconditionally set AZURE_RECORD_MODE=playback as a pipeline variable before the test task runs, overriding the AzureRecordMode pipeline parameter introduced in PR Azure#6893. This caused manually triggered LIVE test runs to still execute in playback mode. The record mode is now fully controlled by the AzureRecordMode parameter chain (release-cli.yml → build-and-test.yml → build-cli.yml). Fixes Azure#7102 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…Azure#7103) The script unconditionally set AZURE_RECORD_MODE=playback as a pipeline variable before the test task runs, overriding the AzureRecordMode pipeline parameter introduced in PR Azure#6893. This caused manually triggered LIVE test runs to still execute in playback mode. The record mode is now fully controlled by the AzureRecordMode parameter chain (release-cli.yml → build-and-test.yml → build-cli.yml). Fixes Azure#7102 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…Azure#7103) The script unconditionally set AZURE_RECORD_MODE=playback as a pipeline variable before the test task runs, overriding the AzureRecordMode pipeline parameter introduced in PR Azure#6893. This caused manually triggered LIVE test runs to still execute in playback mode. The record mode is now fully controlled by the AzureRecordMode parameter chain (release-cli.yml → build-and-test.yml → build-cli.yml). Fixes Azure#7102 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…Azure#7103) The script unconditionally set AZURE_RECORD_MODE=playback as a pipeline variable before the test task runs, overriding the AzureRecordMode pipeline parameter introduced in PR Azure#6893. This caused manually triggered LIVE test runs to still execute in playback mode. The record mode is now fully controlled by the AzureRecordMode parameter chain (release-cli.yml → build-and-test.yml → build-cli.yml). Fixes Azure#7102 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…Azure#7103) The script unconditionally set AZURE_RECORD_MODE=playback as a pipeline variable before the test task runs, overriding the AzureRecordMode pipeline parameter introduced in PR Azure#6893. This caused manually triggered LIVE test runs to still execute in playback mode. The record mode is now fully controlled by the AzureRecordMode parameter chain (release-cli.yml → build-and-test.yml → build-cli.yml). Fixes Azure#7102 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Manually triggered CI runs with
AzureRecordMode=livestill execute tests in playback mode (~30 min instead of ~2 hours).Root Cause
eng/scripts/Set-CliBuildVariables.ps1unconditionally setsAZURE_RECORD_MODE=playbackas a pipeline variable (via##vso[task.setvariable]) before the test task runs. This overrides theenv: AZURE_RECORD_MODEvalue set on the test task from theAzureRecordModepipeline parameter introduced in #6893.Fix
Remove the
AZURE_RECORD_MODEblock from the script. The record mode is now fully controlled by the pipeline parameter chain:release-cli.yml→build-and-test.yml→build-cli.ymlFixes #7102